-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stable): generate latest types & add types for instances - 02.07.2024 #1120
base: master
Are you sure you want to change the base?
Conversation
It's the teams responsibility to handle these cases; if you rename your types in the service contracts repo it's a breaking change. It's quite easy to forget as this feature isn't enforced in the service contract repo in any way, so we can ping them and see if they want to:
@marvrez @miladcognite could you take a look? |
The change from 'Cognite' to 'Cogmono' is related to migration (driven by the infra team) of several Python packages to the mono-repo. I'm not familiar with how we do versioning in the JS SDK, but do you see any issues with releasing a new major version of the SDK? |
Sooo, what's the next step to do here? I could disable auto-gen for visions and annotations API such that we can merge the type updates for data modelling |
for visions: sounds good to me |
NOTE (*): Due to changes done in the following commit https://github.com/cognitedata/service-contracts/commit/191ddb3b200091afa65a3adf9ba2482ff11aa7ed, the types for vision (similar to annotations) were changed from containing 'Cognite' to 'Cogmono'. Not sure what to do here.